Prevent dynamic dispatch from being used #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Swift or Obj-C applications extending UIColor or NSColor like:
would override the internal
toHexString()
which excludes the # and would cause a corrupt URL.This method gets overridden because the class inherits from NSObject and therefore makes use of dynamic dispatching.
Note that Swift 4.0 in unaffected by this bug/feature.
@1ec5 👀